Consulting, Teaching and Mentoring in the Craft of Software Development |
Thinking Craftsman Code Review Checklist
- Dead/Redundant code
- Duplication
- Complexity
- (cyclomatic, large functions, block depth)
- Dependencies ( added/changed )
- Assumptions and their Side effects
- Is it Tell or Ask ?
- Is it easy to Misuse ?
- Is it Global State ?
- (singleton, static variables, global variables)
- Names and Magic Numbers